[ConstraintSystem] Make sure that read-only keypath is preferred for … #25276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…read-only properties This fixes an oversight related to `ReferenceWritableKeyPath` overloads of the KeyPath dynamic member lookup. Original check filtered out only `WritableKeyPath` if the storage is read-only, but it should check for both `WritableKeyPath` and `ReferenceWritableKeyPath`, otherwise program is going to crash at run time. Resolves: rdar://problem/51456614
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test source compatibility |
Contributor
|
Build failed |
Contributor
Author
|
@swift-ci please macOS platform |
Contributor
Author
|
@swift-ci please test macOS platform |
Contributor
|
Build failed |
Member
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…read-only properties
This fixes an oversight related to
ReferenceWritableKeyPathoverloadsof the KeyPath dynamic member lookup. Original check filtered out only
WritableKeyPathif the storage is read-only, but it should check forboth
WritableKeyPathandReferenceWritableKeyPath, otherwise programis going to crash at run time.
Resolves: rdar://problem/51456614