[stdlib] Rename VectorProtocol.Scalar to VectorSpaceScalar.
#25374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A step towards machine learning optimizer revamp. The next step is to make `Tensor.VectorSpaceScalar = Float`. This makes `Tensor` scalar multiplication always work with `Float` instead of `Scalar`. Renaming `VectorProtocol.Scalar` is necessary. Otherwise, `Scalar` is ambiguous within `Tensor`'s type context: it may refer to either: - The witness type of `VectorProtocol.Scalar`, or - The `Scalar` generic parameter.
|
@swift-ci Please clean test tensorflow |
rxwei
approved these changes
Jun 12, 2019
|
@swift-ci please clean test tensorflow |
|
Verified that all tests pass locally. |
dan-zheng
added a commit
to dan-zheng/swift
that referenced
this pull request
Jun 12, 2019
Accidentally added in swiftlang#25374.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A step towards machine learning optimizer revamp.
The next step is to make
Tensor.VectorSpaceScalar = Float.This makes
Tensorscalar multiplication always work withFloatinstead of
Scalar.Renaming
VectorProtocol.Scalaris necessary. Otherwise,Scalaris ambiguous within
Tensor's type context: it may refer to either:VectorProtocol.Scalar, orScalargeneric parameter.