[5.1 06/12][CSDiag] Always find and set correct declaration context for sub-expr type-check #25568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ession type-check Replace dedicated method with `typeCheckChildIndependently` always setting the closest possible declaration context for type-check call. This fixes a problem where sub-expression comes from multiple levels or nested closures but CSDiag didn't re-typecheck parent closure. Resolves: rdar://problem/50869732 (cherry picked from commit a5df786)
(cherry picked from commit 4fdc9ff)
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace dedicated method with
typeCheckChildIndependentlyalwayssetting the closest possible declaration context for type-check call.
This fixes a problem where sub-expression comes from multiple levels
or nested closures but CSDiag didn't re-typecheck parent closure.
Issue: rdar://problem/50869732
Scope: Diagnostics, in subset of cases where there multiple nested single-statement closures involved.
Risk: Low.
Testing: Added compiler regression tests.
Reviewed by: @DougGregor
Resolves: rdar://problem/50869732