[5.1] TypeChecker: Fix dynamic replacement of protocol default implementation #26090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entation Ignore the decl inside the protocol decl. Before this patch we would fail in the type checker with ambigious symbols to be replaced: the default implementation and the procotol requirement. Scope: Affects dynamic replacements of protocol extensions. Risk: Low. We remove one entry from the found candidates: the protocol requirement. Testing: Regression tests. rdar://52863618
Contributor
Author
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore the decl inside the protocol decl.
Before this patch we would fail in the type checker with ambigious symbols to be replaced:
the default implementation and the procotol requirement.
Scope: Affects dynamic replacements of protocol extensions.
Risk: Low. We remove one entry from the found candidates: the protocol
requirement.
Testing: Regression tests.
rdar://52863618