[5.1][ConstraintSystem] trySimplifyToExpr shouldn't rely on locator bein…
#26092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g always anchored If constraint system is used as part of the declaration checker to e.g. verify generic requirements for a witness, locators are not going to have an anchor. Resolves: [SR-10728](https://bugs.swift.org/browse/SR-10728) Resolves: rdar://problem/50987089 (cherry picked from commit ae5cce4)
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g always anchored
If constraint system is used as part of the declaration checker to
e.g. verify generic requirements for a witness, locators are not going
to have an anchor.
Issue: rdar://problem/50987089
Scope: Diagnostics, when declaration checker validates generic requirements.
Risk: Very Low.
Testing: Added compiler regression tests.
Reviewed by: @DougGregor
Resolves: SR-10728
Resolves: rdar://problem/50987089
(cherry picked from commit ae5cce4)