[5.1] SourceKit/Formatting: avoid indenting for consecutive dot-member calls #26121
+107
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please nominate |
| } | ||
| Ptr = LineStart; | ||
|
|
||
| // The <= here is to allow for non-inclusive range end positions at EOF |
Contributor
There was a problem hiding this comment.
Should this comment be deleted now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Consecutive dot member function calls is a common pattern in SwiftUI codebase. They should be aligned when automatically indented from the editor. This patch teaches sourcekitd to check such pattern and handle it specifically.
Scope: Editor Tooling/Indentation
Issue: rdar://52392291
Risk: Very Low
Testing: Regression tests added and updated
Reviewer: Argyrios Kyrtzidis (@akyrtzi)