[5.1] Replace all 9999 availability in non-stdlib tests. (#26109) #26145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace all 9999 availability in non-stdlib tests with the appropriate platform availability.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
(Paradoxically, it's less important to get this on 5.1 than it is on master, since nothing with availability > 5.1-aligned SDK versions should ever land on this branch, so there's no need to disambiguate. Still, good to do this, if only because it makes cherry-picking other changes across easier.) |
Contributor
Author
|
@swift-ci nominate |
…c_replacement_opaque_result Fix test/Interpreter/dynamic_replacement_opaque_result.swift
Contributor
Author
|
@swift-ci test |
Contributor
|
Build failed |
Contributor
|
Build failed |
Contributor
Author
|
"Unresolved" lang/swift/address_of/TestSwiftAddressOf.py test on linux. Re-running to see if it persists. |
Contributor
Author
|
@swift-ci please test linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all 9999 availability in non-stdlib tests with the appropriate platform availability.
#26109 cherry-picked for 5.1 branch.
Explanation: We still have 9999 availability sprinkled throughout the tests and standard library. This change replaces all the non-stdlib test availability with the appropriate macOS, iOS, tvOS and watchOS versions. It's important to get these changes landed before people start adding features synced with future Swift versions to avoid ambiguity.
Scope: Availability annotations only, only in tests.
Risk: Low. In some cases, it's possible that tests that previously ran or did not run could be enabled or disabled due to availability changes, but we already landed this on master and have let is shake out for a couple days.
Testing: Full integration testing.
Reviewer: @jckarter
Radar: rdar://problem/53163936