Resubmit "[CMake][NFC] Introduce component targets for proper dependency tracking" #26578
Conversation
bulbazord
changed the title
|
@swift-ci please smoke test |
|
@swift-ci please clean test |
|
Build failed |
|
Build failed |
|
@swift-ci please smoke test |
|
@swift-ci please clean test |
|
Build failed |
|
Build failed |
|
@swift-ci please clean test Linux platform |
|
Build failed |
|
@swift-ci please clean test |
|
Build failed |
|
Build failed |
|
@swift-ci please clean test Linux platform |
|
Build failed |
bulbazord
force-pushed
the
component-targets-done-right
branch
from
38e7c25 to
1f3bd32
Compare
|
@swift-ci please clean test |
|
Build failed |
|
Build failed |
|
@swift-ci please test Linux platform |
bulbazord
force-pushed
the
component-targets-done-right
branch
from
1f3bd32 to
5a15a02
Compare
|
@swift-ci please clean test |
|
Build failed |
|
Build failed |
bulbazord
force-pushed
the
component-targets-done-right
branch
from
5a15a02 to
41ce8cb
Compare
|
Build failed |
|
@swift-ci please clean test |
|
Build failed |
|
@swift-ci please clean test |
|
Build failed |
This commit introduces a CMake target for each component, adds install targets for them, and switches build-script-impl to use the target `install-components` for installation. Each of the targets for each component depends on each of the individual targets and outputs that are associated with the corresponding swift-component. This is equivalent to what already exists, because right now install rules are only generated for components that we want to install. Therefore, this commit should be an NFC. This is a resubmission (with modifications) of an earlier change. I originally committed this but there were problems with some installation rules.
bulbazord
force-pushed
the
component-targets-done-right
branch
from
41ce8cb to
61be4d9
Compare
|
@swift-ci please clean test |
|
Build failed |
|
Build failed |
|
Looks like it's working now! @compnerd |
|
I'm not sure if there's something wrong, but from the results of the Toolchain builds it looks like they succeeded. I think this is good to go in 😃 |
3 participants
This commit introduces a CMake target for each component, adds install targets
for them, and switches build-script-impl to use the target
install-componentsfor installation. Each of the targets for each component depends on each
of the individual targets and outputs that are associated with the
corresponding swift-component.
This is equivalent to what already exists, because right now install rules are
only generated for components that we want to install. Therefore, this commit
should be an NFC.
NOTE: This is a resubmission (with modifications) of an earlier change. I originally
committed this but there were problems with some installation rules.