NFC: Excise ParseableInterface from code #27175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 13, 2019 11:45
NFC, they were just separate enough to warrant splitting into their own file.
…oader Rename this class to better fit the user-facing name.
Rename ParseableInterfaceBuilder to accompany ModuleInterfaceLoader
…here Now that we've settled on Module Interface as the name, let's remove the vestiges of "Parseable Interfaces"
Also remove uses of -emit-parseable-module-interface from tests
jrose-apple
approved these changes
Sep 13, 2019
Contributor
Author
|
@swift-ci please test |
harlanhaskins
pushed a commit
to apple/swift-lldb
that referenced
this pull request
Sep 14, 2019
This patch adopts the new APIs in swiftlang/swift#27175 and removes the usage of `-emit-parseable-module-interface[-path]` in favor of the final flags, `-emit-module-interface[-path]`.
vedantk
pushed a commit
to apple/swift-lldb
that referenced
this pull request
Sep 17, 2019
This patch adopts the new APIs in swiftlang/swift#27175 and removes the usage of `-emit-parseable-module-interface[-path]` in favor of the final flags, `-emit-module-interface[-path]`. (cherry picked from commit 3a3b6fa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few cleanups to module interface loading
emit-parseable-module-interface-pathandbuild-module-from-parseable-interface