[AutoDiff] Fix member loading for AD-generated structs/enums. #27264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `IterableDeclContext::loadAllMembers` for structs/enums generated during differentiation transform. Previously, this patch disabled `loadAllMembers` for AD-generated structs/enums: swiftlang@7e89bee This caused a SIL verification failure for test/AutoDiff/autodiff_generated_decl_member_loading.swift because enum members were not loaded. Now, `loadAllMembers` is re-enabled. Other necessary fixes: - Generated structs/enums are set to implicit. - Since implicit declarations are not printed via `-emit-sil`, data structure generation tests now rely on `-Xllvm -debug-only=differentiation`. - Remove calls to `NominalTypeDecl::setBraces`. - Strategically set `SourceLoc` for `EnumElementDecl` and `EnumCaseDecl` to prevent duplicate enum cases from printing. Resolves TF-805.
Contributor
Author
|
@swift-ci Please test tensorflow |
|
Did you forget to |
Contributor
Author
Yes, thanks for the catch! Added in 2b8e854. |
marcrasi
approved these changes
Sep 20, 2019
Contributor
Author
|
@swift-ci Please test tensorflow |
Contributor
Author
|
@swift-ci Please test tensorflow macOS |
rxwei
approved these changes
Sep 20, 2019
dan-zheng
commented
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
IterableDeclContext::loadAllMembersfor structs/enums generated during differentiation transform.Previously, 7e89bee disabled
loadAllMembersfor AD-generated structs/enums.This caused a SIL verification failure for
test/AutoDiff/autodiff_generated_decl_member_loading.swiftbecause enum members were not loaded.Now,
loadAllMembersis re-enabled. Other necessary fixes:-emit-sil, data structure generation tests now rely on-Xllvm -debug-only=differentiation.NominalTypeDecl::setBraces.SourceLocforEnumElementDeclandEnumCaseDeclto prevent duplicate enum cases from printing.Resolves TF-805.