[NFC] [AutoDiff] Minor cleanup. #27509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set default true for `-enable-experimental-differentiable-programming` flag on tensorflow branch. The default will be false on master. - Rename unit test to AutoDiffIndexSubset.cpp, since `AutoDiffIndexSubset` is the tested data structure.
|
@swift-ci Please test tensorflow |
rxwei
approved these changes
Oct 3, 2019
rxwei
reviewed
Oct 3, 2019
|
@swift-ci Please test tensorflow |
|
Looks like you didn't change CMakeLists. |
|
@swift-ci Please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-enable-experimental-differentiable-programmingflagon tensorflow branch. The default will be false on master.
AutoDiffIndexSubset.cpp, sinceAutoDiffIndexSubsetisthe tested data structure.