[SILProfiler] Do not visit closure bodies twice #27573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closure bodies should only be visited for coverage purposes once -- when the associated SILFunction is created. This resolves an assertion failure about an empty region stack (this root cause of which was double-visitation of a closure body).
|
@swift-ci smoke test and merge |
slavapestov
reviewed
Oct 8, 2019
| if (skipExpr(E)) | ||
| return {true, E}; | ||
|
|
||
| // Profiling for closures should be handled separately. Do not visit |
There was a problem hiding this comment.
You might want to consider creating a new CoverageASTWalker or similar to extract some of the common logic between your ASTWalker implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closure bodies should only be visited for coverage purposes once -- when
the associated SILFunction is created.
This resolves an assertion failure about an empty region stack (this
root cause of which was double-visitation of a closure body).