[AutoDiff] [Serialization] Fix '@differentiable(linear)' SIL function type serialization. #27659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… type serialization. Before `DifferentiabilityKind` was introduced, a function was either `@differentiable` or not `@differentiable`. `DifferentiabilityKind` added a third option: `@differentiability(linear)`. SIL function type serialization did not care about the specific `DifferentiabilityKind` but just whether the function is differentiable -- it is now fixed in this patch. Resolves [TF-903](https://bugs.swift.org/browse/TF-903).
|
@swift-ci please test tensorflow |
dan-zheng
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
DifferentiabilityKindwas introduced, a function was either@differentiableor not@differentiable.DifferentiabilityKindadded a third option:@differentiability(linear). SIL function type serialization did not care about the specificDifferentiabilityKindbut just whether the function is differentiable -- it is now fixed in this patch.Resolves TF-903.