[NameLookup] Fix opaque decl astscope #27743
Conversation
|
@swift-ci please test |
…ve clause environment.
davidungar
force-pushed
the
fix-opaque-decl-astscope
branch
from
15d613b to
2e8920b
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
| << sourceFile->getFilename() << "\n"; | ||
| // The check is costly, and inactive lookups will end up here, so don't | ||
| // do the check unless we can't find the startingScope. | ||
| const bool isInInactiveClause = |
There was a problem hiding this comment.
I don’t understand why we need this part, of the parser isn’t going to add these decls in the first place for inactive regions?
There was a problem hiding this comment.
Tx for looking this over.
The idea is that lookups to things in inactive clauses may creep back in at some point. If they do, this part will output a more specific message for debugging, and also, as per your preference, will crash the compilation. It only runs when the ASTScope code cannot find the starting scope anyway, so it doesn't slow down compilation unless there's an error.
When someday, we rip out all the code that passed DeclContexts into UnqualifiedLookup, the whole did-not-find starting scope stuff will get ripped out.
|
As per offline conversation with @DougGregor , am proceeding to merge. |
|
Likely fixes rdar://56334618 |
3 participants
Do not try to do lookups on OpaqueDecls that are in inactive clauses.
Also, fail the compilation for any lookups into inactive clauses.