[TF-812] Defines remaining derivatives for tgmath functions.

[vguerra]

The following math functions are now differentiable:

• remainder
• fmod
• ceil
• floor
• round
• trunc

Resolves TF-812

[dan-zheng]

Rather than using @differentiable(..., vjp: ...) on the original tgmath functions, could you please use @differentiating on the derivative functions?

[vguerra]

Rather than using @differentiable(..., vjp: ...) on the original tgmath functions, could you please use @differentiating on the derivative functions?

Sure, will do that. Commit coming soon.

[vguerra]

hello @dan-zheng ... I tried to define the derivates using the @differentiating attribute but unfortunately I get a compiler crash... you can see the details of the crash in this gist. Does this ring a bell? Is it an issue you might have seen before?

[dan-zheng]

hello @dan-zheng ... I tried to define the derivates using the @differentiating attribute but unfortunately I get a compiler crash... you can see the details of the crash in this gist. Does this ring a bell? Is it an issue you might have seen before?

Thanks for sharing! This issue looks like TF-429: the differentiation transform does not yet support -enable-library-evolution (previously called -enable-resilience). The standard library is currently built with -enable-library-evolution.

I wouldn't expected @differentiable vs @differentiating attribute to have an effect on TF-429. I wonder if the crash occurs with @differentiable attribute? I'll trigger CI to find out.

[dan-zheng]

@swift-ci Please test tensorflow

[vguerra]

This PR, as it is, compiles fine in my machine. Let’s see what’s the result of the CI.

[dan-zheng]

CI passes.

@vguerra: would you mind starting another PR using @differentiating attributes to register derivatives? If CI fails for @differentiating attributes, we can minimize the issue and see if it's relevant to TF-429.

[vguerra]

hi @dan-zheng .. sure, I can do that. I'll start a new PR.

[vguerra]

I've started a new PR #28108

[dan-zheng]

Let's close this in favor of #28108, since it uses @differentiating to register derivatives instead of @differentiable.