Skip to content

Conversation

@marcrasi
Copy link

  1. There was some logic that occasionally sets the generic signature of the witness to be different from the generic signature of the attribute. This is causing a problem [1] for me, and tests don't fail when I delete the logic. So I deleted the logic.
  2. SILGen was not generating witnesses for getters. Now it does.

[1] I'm trying to make the differentiation pass populate both attributes and witnesses, so that we can smoothly move it from attributes to witnesses in small pieces without breaking anything. But the mismatched generic signatures make it difficult to tell which attributes and witnesses correspond to each other.

@marcrasi marcrasi requested review from dan-zheng and rxwei November 21, 2019 01:58
@marcrasi marcrasi force-pushed the improve-diff-witness-silgen branch from a396f28 to fa880fb Compare November 21, 2019 01:59
@marcrasi
Copy link
Author

@swift-ci please test tensorflow

@marcrasi marcrasi merged commit bcbe65e into swiftlang:tensorflow Nov 21, 2019
@marcrasi marcrasi deleted the improve-diff-witness-silgen branch November 21, 2019 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants