[AutoDiff] Fix differentiability witness SIL serialization. #28463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create `SILSerializer::DifferentiabilityWitnessesToEmit` to track differentiability witnesses referenced by `differentiability_witness_function` instructions. These witnesses need to be serialized. - Move differentiability witness serialization before SIL function serialization but after visiting SIL functions (`differentiability_witness_function` instructions). - Use `-emit-sorted-sil` in test/AutoDiff/sil_differentiability_witness.sil for deterministic ordering for printing and deserialization.
|
@swift-ci Please clean test tensorflow |
dan-zheng
requested review from
marcrasi and
rxwei
and removed request for
rxwei
|
Merging since mirror patch #28461 was approved. |
This was referenced Nov 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SILSerializer::DifferentiabilityWitnessesToEmitto trackdifferentiability witnesses referenced by
differentiability_witness_functioninstructions.These witnesses need to be serialized.
but after visiting SIL functions (
differentiability_witness_functioninstructions).
-emit-sorted-silintest/AutoDiff/sil_differentiability_witness.silfor deterministic ordering for printing and deserialization.
Mirror of #28461 applied to
tensorflowbranch to keep orthogonal PRs small.test/AutoDiff/sil_differentiability_witness_reference_serialization.silwas created by @marcrasi.