[AutoDiff] Support derivative registration for more declaration kinds. #28468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
@differentiatingand@transposingattributes support more originaldeclaration kinds: computed properties, subscripts, and initializers.
DifferentiatingAttrandTransposingAttrto store anAbstractFunctionDeclrepresenting the original declaration, instead of aFuncDecl.DeclNames.TypeChecker::lookupFuncDecla static function inTypeCheckAttr.cpp.@differentiatingnow has feature parity with@differentiable(jvp: ..., vjp: ...)for derivative registration.This is a necessary step towards making
@differentiatingand@transposingthe canonical mechanism for registering derivative/transpose functions.
Registering non-
funcdeclaration derivatives with@differentiableattributejvp:/vjp:labels is now explicitly rejected.Resolves TF-281.
Todos:
@transposingattribute with initializer originaldeclarations.
@differentiableattribute type-checking diagnosticsfor
@differentiating/@transposingattribute type-checking.Newly supported:
Newly diagnosed: