[AutoDiff] Add differentiability_witness_function verification.
#28501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assert that `differentiability_witness_function` is never constructed with null witness. Verify that type of `differentiability_witness_function` instruction matches the type of the witnessed SIL function.
|
@swift-ci Please test tensorflow |
|
Running extended test suite on |
rxwei
approved these changes
Nov 28, 2019
|
Closing; replaced by #28505 to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assert that
differentiability_witness_functionis never constructed withnull witness.
Verify that type of
differentiability_witness_functioninstruction matchesthe type of the witnessed SIL function.
Motivation:
differentiability_witness_functionhas been missing verification, oops. Verification can help avoid segfaults like #28451 (comment).