Skip to content

Conversation

@dan-zheng
Copy link
Contributor

…8418)"

This reverts commit 486e2e7.


This fixes LLDB and the Swift REPL on macOS.

Before:

$ swift --version
Swift version 5.1.2-dev (Swift 3cbc14893e)
Target: x86_64-apple-darwin18.7.0
$ swift
dyld: Library not loaded: @rpath/LLDB.framework/Versions/A/LLDB
  Referenced from: /Library/Developer/Toolchains/swift-tensorflow-DEVELOPMENT-2019-12-09-a.xctoolchain/usr/bin/lldb
  Reason: image not found

After:

$ swift
Welcome to Swift version 5.1.2-dev (Swift f920eeee0a).
Type :help for assistance.
  1>

I debugged this issue by comparing the toolchain directory structure: System/Library/PrivateFrameworks is missing from the broken toolchain.

diff --git a/ok.txt b/bad.txt
index 62fb78a..6ec76d6 100644
--- a/ok.txt
+++ b/bad.txt
@@ -1,1028 +1,5 @@
 .
 ├── Info.plist
-├── System
-│   └── Library
-│       └── PrivateFrameworks
-│           └── LLDB.framework
-│               ├── Headers -> Versions/Current/Headers
-│               ├── LLDB -> Versions/Current/LLDB
-│               ├── Resources -> Versions/Current/Resources
-│               └── Versions
-│                   ├── A
-│                   │   ├── Headers
...

…iftlang#28418)"

This reverts commit 486e2e7.

This fixes LLDB and the Swift REPL on macOS.
@dan-zheng dan-zheng added the tensorflow This is for "tensorflow" branch PRs. label Dec 10, 2019
@dan-zheng dan-zheng requested a review from burmako December 10, 2019 05:06
@burmako burmako merged commit 1c8cb18 into swiftlang:tensorflow-merge Dec 10, 2019
Copy link

@burmako burmako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tensorflow This is for "tensorflow" branch PRs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants