Skip to content

Conversation

@dan-zheng
Copy link
Contributor

@dan-zheng dan-zheng commented Jul 28, 2020

PythonKit was removed as a Swift build dependency in 9f0e0a6.

PythonKit was instead added as a CMake dependency of tensorflow/swift-apis in
tensorflow/swift-apis#1045.


Fixes build error:

[./utils/build-script] NOTE: using preset "tensorflow_linux,tensorflow_swift_apis,no_test", which expands to

./utils/build-script --assertions --swift-enable-ast-verifier=0 '--swift-install-components=autolink-driver;compiler;clang-resource-dir-symlink;stdlib;swift-remote-mirror;sdk-overlay;parser-lib;toolchain-tools;license;sourcekit-inproc' '--llvm-install-components=llvm-cov;llvm-profdata;IndexStore;clang;clang-resource-headers;compiler-rt;clangd;lld' --llbuild --swiftpm --xctest --libicu --libcxx --build-ninja --install-llvm --install-swift --install-lldb --install-llbuild --install-swiftpm --install-xctest --install-libicu --install-prefix=/usr --install-libcxx --install-sourcekit-lsp --build-swift-static-stdlib --build-swift-static-sdk-overlay --build-swift-stdlib-unittest-extra --test-installable-package --toolchain-benchmarks --install-destdir=/swift-base/swift/swift-nightly-install --installable-package=/swift-base/swift/swift-tensorflow-LOCAL-2020-07-28-a-.tar.gz --build-subdir=buildbot_linux --lldb --release --test --validation-test --long-test --stress-test --test-optimized --foundation --libdispatch --indexstore-db --sourcekit-lsp '--lit-args=-v --time-tests' --lldb-test-swift-only --install-foundation --install-libdispatch --reconfigure --skip-test-cmark --skip-test-lldb --skip-test-swift --skip-test-llbuild --skip-test-swiftpm --skip-test-xctest --skip-test-foundation --skip-test-libdispatch --skip-test-playgroundsupport --skip-test-libicu --skip-test-indexstore-db --skip-test-sourcekit-lsp --pythonkit --install-pythonkit --test-installable-package= --tensorflow-swift-apis --install-tensorflow-swift-apis

error: unknown setting: pythonkit

PythonKit was removed as a Swift build dependency in 9f0e0a6.

PythonKit was instead added as a CMake dependency of tensorflow/swift-apis in
tensorflow/swift-apis#1045.
@dan-zheng dan-zheng requested a review from compnerd July 28, 2020 19:28
@dan-zheng
Copy link
Contributor Author

Merging to unblock the master -> tensorflow merge. Happy to address feedback later!

@dan-zheng dan-zheng merged commit 538d62b into swiftlang:tensorflow-stage Jul 28, 2020
@dan-zheng dan-zheng deleted the tensorflow_remove_pythonkit branch July 28, 2020 19:35
@compnerd
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants