Merge 2020-08-31 into tensorflow #33755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swift class deinit decl can be implicitly synthesized when emitting swiftmodule, so swiftmodule always have deinit decl. So resolution of x-refs to deinit of swift class always success. But when x-refs points deinit of clang imported class, it always failed because clang importer doesn't force to synthesize deinit before looking up. x-refs to deinit decl appears in only deinit of its subclasses, so it's serialized only when deinit have body. And deinit has body only on SIB because deinit is always non-inlinable. It means that this missing of deinit creation can be problem only on SIB This commit changes to force to synthesize class deinit decl before looking up members.
This changes the python interpreter used to invoke the tests to Python3. Python2 has been EOL'ed by the Python Software Foundation. This migration enables the Swift test suite to run with Python 3 instead.
…ot a PatternBindingInitializer The function builder transform creates pattern bindings parented in other DeclContexts. If those pattern binding initializer expressions in turn contain multi-statement closures, we will try to perform unqualified lookups from those contexts when we get around to type checking the closure body. Change some unconditional casts to conditional casts in ASTScope lookup, to handle this case. The casts are only performed while checking if the initializer context is part of a 'lazy' property, which doesn't apply here. Fixes <rdar://problem/67265731>.
Have left in an assert since it would be nice to get a test case for when this actually occurs. Resolves rdar://67412430
Adding a new unsolved constraint is redundant, as it's already present in the inactive list. Noticed by inspection.
…rn-binding-init-function-builder AST: Fix ASTScopeLookup crash if a PatternBindingEntry's context is not a PatternBindingInitializer
…cessors inside classes (#33602)
This reverts commit 9b88288.
This reverts commit b8976a3.
…by adding scanner "loaders" to the ASTContext.
[gardening] Move some code between sourcekitd and libIDE
[IDE] Skip visiting constructor references when the decl is unknown
…instead of symbol name matching
…en-it-before-its-brand-new [CS] Don't use TMF_GenerateConstraints in simplifyConstraint
…ompletion exprs and type check them for code completion. Fixes up some tests marked as non-ideal to give the ideal result now too.
…ayed parsing as well We were previously only doing it when parsing up front.
…formances is ncessary at the moment
This is NFC because only literal protocols are tracked at the moment.
Forward propagate (subtype -> supertype) only literal conformance
requirements since that helps solver to infer more types at
parameter positions.
```swift
func foo<T: ExpressibleByStringLiteral>(_: String, _: T) -> T {
fatalError()
}
func bar(_: Any?) {}
func test() {
bar(foo("", ""))
}
```
If one of the literal arguments doesn't propagate its
`ExpressibleByStringLiteral` conformance, we'd end up picking
`T` with only one type `Any?` which is incorrect.
This is not going to be necessary once bindings are filtered based
of requirements placed on a type variable.
CSGen: Infer generic arguments for explicit closure result types
…9fefab99d7dc7b [ownership] Move SemanticARCOpts into a separate folder in preparation for splitting into multiple small pseudo-passes.
…bca2d5cb988ddb
[Concurrency] Import Objective-C methods with completion handlers as async
…NATIVE_CLANG_TOOLS_PATH (#33675)
…-versioned directory When clients specify an output directory without SDK version, the script will change the input so we emit all prebuilt module caches into SDK-versioned directories without modifying the client side. rdar://67951012
[Parse][IDE] Various parser fixes for code completion
[ConstraintSystem] NFC: Clarify why upward propagation of literal conforma…
swift_build_sdk_interfaces.py: adjust output directory path to an SDK-versioned directory
This reverts commit 57f2944.
On-Bot Debugging Of Test Failure
Fix tensorflow branch SourceKit merge conflicts related to InMemoryOutputFileSystem.
`-print-ast` no longer prints the AST if diagnostics are emitted. Edit test case to no longer emit diagnostics.
Contributor
Author
|
Please test with following PRs: @swift-ci Please clean test TensorFlow |
dan-zheng
approved these changes
Sep 2, 2020
This was referenced Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weekly merge of latest changes to tensorflow branch.