Skip to content

Conversation

@jrose-apple
Copy link
Contributor

Underlying issue discussed in #4622. Filed rdar://problem/28313536 to make sure we re-enable it.

Discussed in swiftlang#4622. Filed
rdar://problem/28313536 to make sure we re-enable it.
@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test and merge

@jrose-apple
Copy link
Contributor Author

In the spirit of "don't just let flaky tests flake": @benlangmuir , any idea what's up with the completion test failure here? https://ci.swift.org/job/swift-PR-osx-smoke-test/1687/

But since this PR is itself helping with flaky tests:

@swift-ci Please smoke test OS X platform

@benlangmuir
Copy link
Contributor

@jrose-apple huh, never seen that failure before. I'll take a look.

@jrose-apple jrose-apple merged commit d1b02d0 into swiftlang:master Sep 15, 2016
@jrose-apple jrose-apple deleted the objc_nonnull_lie_hack.swift branch September 15, 2016 15:24
@benlangmuir
Copy link
Contributor

@jrose-apple I ran that test in a loop 30,000 times without fail. Then I tried deleting the clang module cache directory in the middle of the test. Usually, that produced no completions at all, but occasionally it produced the same symptoms as the failure in that PR test build. So far that's the only guess I have about what happened, and deleting the cache directory mid-build is a big no-no (deleting the individual .pcms should be okay).

@jrose-apple
Copy link
Contributor Author

Hm. Maybe it's something similar to this test itself, where we use different API notes in different tests, and cache the result? (See #4622 for more discussion.)

@gribozavr
Copy link
Contributor

@benlangmuir I think what causes the failure is a different test run order.

aaditya-chandrasekhar pushed a commit to val-verde/swift that referenced this pull request Sep 30, 2022
[pull] swiftwasm-release/5.7 from release/5.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants