[3.0] Warn for Optionals in String Interpolation Segments #5248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic extension of the optional-to-any AST walker to incorporate warnings for optionally-typed expressions in string interpolation segments that can lead to unintended behavior. Specifically let x = Optional<Int>.some(2) print(x) // "Optional(2)"
CodaFi
changed the title
Contributor
Author
|
@swift-ci please test OS X platform. |
Contributor
Author
|
@jrose-apple bump |
Contributor
|
I think at this point we're only taking critical changes on the 3.0 branch. |
Contributor
Author
|
Very well, just needed some clarification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is an extension to optional-as-any warnings introduced to diagnose cases where an optional expression was being upcast to
Anyby mistake. We now emit a warning in the case that a user writes an optional-typed expression in a string interpolation segment. In addition, we offer fixits to help the user either explicitly request this withString(describing:)or offer to insert the start of a default value expression. As a warning this change is not source-breaking and fairly low risk.@jrose-apple @rudkx How does it look?