-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[Compiling Swift Generics Book] Fixing some typos #61604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Compiling Swift Generics Book] Fixing some typos #61604
Conversation
|
Thanks! |
|
Ok, I'm not sure I'll have time to finish my reading of the whole book as soon as I thought after all, so we might as well merge the typo fixes so far and I could always open a subsequent PR when I get time to resume reading and if I find more typos to fix then 😉 @slavapestov since I've added more commits since your initial review & approval, feel free to double-check the new ones I've added since, then merge the PR if you're ok with them all 🙂 |
|
@swift-ci Please smoke test and merge |
|
Wow, a reply only 26s after being ping'd, impressive… I'm not sure who I'd bet on in a race between you and Noby 🏇 😄 |
|
@slavapestov seems CI failed for unclear reasons, and thus this was never merged after all 😅 |
|
@swift-ci please smoke test Linux |
|
@AliSoftware Could you clean up the commit history? |
3fcb730 to
c893f59
Compare
|
@AnthonyLatsis Done, all commits squashed into one now |
|
@swift-ci please smoke test Thanks! |
|
@swift-ci please smoke test |
|
@AliSoftware Could you look into the conflict? It has been almost 2 years, so the typos might have been fixed. For the future, please do not hesitate to ping the reviewers once every two weeks or so if your pull request stagnates like this. |
|
I took a look at the suggestions from this PR vs the latest content of the |
While I'm reading @slavapestov 's PDF from https://forums.swift.org/t/compiling-swift-generics-part-i/60898, I've noticed a couple of small typos in the book, so this PR aims to fix the ones I found.
I'm still at the very beginning of my reading, so not much fixes so far. I'll probably add more commits to that PR as I find more typos down the road, hence why I'll keep this as draft for the moment.
Besides, I'm reading the PDF from my iPad and thus making those changes — and submitting them — from the GitHub iPad app… which might not be the easiest and nicest way to navigate and edit the large
.texfile 😅 (I'll likely add the future commits / typo fixes from a computer with better way to navigate said.texfile 😛 )… but I still wanted to start submitting these first 3 ones early, before I forgot and failed to find them again by the time I'll have access to a Mac tomorrow 😉