Skip to content

Conversation

@AliSoftware
Copy link
Contributor

While I'm reading @slavapestov 's PDF from https://forums.swift.org/t/compiling-swift-generics-part-i/60898, I've noticed a couple of small typos in the book, so this PR aims to fix the ones I found.


I'm still at the very beginning of my reading, so not much fixes so far. I'll probably add more commits to that PR as I find more typos down the road, hence why I'll keep this as draft for the moment.

Besides, I'm reading the PDF from my iPad and thus making those changes — and submitting them — from the GitHub iPad app… which might not be the easiest and nicest way to navigate and edit the large .tex file 😅 (I'll likely add the future commits / typo fixes from a computer with better way to navigate said .tex file 😛 )… but I still wanted to start submitting these first 3 ones early, before I forgot and failed to find them again by the time I'll have access to a Mac tomorrow 😉

@slavapestov
Copy link
Contributor

Thanks!

@AliSoftware AliSoftware marked this pull request as ready for review October 25, 2022 17:46
@AliSoftware
Copy link
Contributor Author

Ok, I'm not sure I'll have time to finish my reading of the whole book as soon as I thought after all, so we might as well merge the typo fixes so far and I could always open a subsequent PR when I get time to resume reading and if I find more typos to fix then 😉

@slavapestov since I've added more commits since your initial review & approval, feel free to double-check the new ones I've added since, then merge the PR if you're ok with them all 🙂

@slavapestov
Copy link
Contributor

@swift-ci Please smoke test and merge

@AliSoftware
Copy link
Contributor Author

Wow, a reply only 26s after being ping'd, impressive… I'm not sure who I'd bet on in a race between you and Noby 🏇 😄

@AliSoftware
Copy link
Contributor Author

AliSoftware commented Nov 23, 2022

@slavapestov seems CI failed for unclear reasons, and thus this was never merged after all 😅

@AnthonyLatsis
Copy link
Collaborator

@swift-ci please smoke test Linux

@AnthonyLatsis
Copy link
Collaborator

@AliSoftware Could you clean up the commit history?

@AliSoftware AliSoftware force-pushed the compiling-swift-generics-book/typos-1 branch from 3fcb730 to c893f59 Compare November 23, 2022 20:18
@AliSoftware
Copy link
Contributor Author

@AnthonyLatsis Done, all commits squashed into one now

@AnthonyLatsis
Copy link
Collaborator

@swift-ci please smoke test

Thanks!

@AnthonyLatsis
Copy link
Collaborator

@swift-ci please smoke test

@AnthonyLatsis AnthonyLatsis added documentation generics Feature: generic declarations and types labels Nov 23, 2022
@AnthonyLatsis
Copy link
Collaborator

@AliSoftware Could you look into the conflict? It has been almost 2 years, so the typos might have been fixed. For the future, please do not hesitate to ping the reviewers once every two weeks or so if your pull request stagnates like this.

@AliSoftware
Copy link
Contributor Author

I took a look at the suggestions from this PR vs the latest content of the .tex file and most of the content have changed or be reworded since (couldn't find the sentences I fixed typos on in the latest main at least), so I think it's ok to close 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation generics Feature: generic declarations and types

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants