-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[Interop][SwiftToCxx] Introduces swift::Expected #61823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hyp
merged 14 commits into
swiftlang:main
from
Robertorosmaninho:interop/ExpectedClassForErrorHandling
Dec 17, 2022
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
0b217b9
[Interop][SwiftToCxx] Initial implementation
Robertorosmaninho c9d15ae
[Interop][SwiftToCxx] Improving std::Expected constructors
Robertorosmaninho c42dfea
[Interop][SwiftToCxx] Creating test cases for swift::Expected
Robertorosmaninho 3f6351d
[Interop][SwiftToCxx] Add new line
Robertorosmaninho 6d16962
[Interop] [SwiftToCxx] Using buffer to create an instance for either …
Robertorosmaninho 74450be
[Interop][SwiftToCxx] Moving the max function to `_impl` namespace an…
Robertorosmaninho 782bc6a
[Interop][SwiftToCxx] Moving swift::Expected to _SwiftStdlibCxxOverlay.h
Robertorosmaninho a2633d9
[Interop][SwiftToCxx] Fixing swift-expected-execution.cpp test
Robertorosmaninho ce666ac
[Interop][SwiftToCxx] Adding support to return `Swift::Expected` when…
Robertorosmaninho 80e7546
[Interop][SwiftToCxx] Replacing static by inline on _SwiftStdlibCxxOv…
Robertorosmaninho 5fc55b6
Add <new> into every bridge header
Robertorosmaninho 878f162
test a potential modules-related fix for windows test failure
hyp 2c9e807
another speculative fix to windows test failure
hyp 6d0dd0e
[interop][SwiftToCxx] workaround windows failure with Error new use i…
hyp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can extract the return type printing code into a closure in this function, to avoid repeating this code?