Skip to content

[sil-optimizer] Add LLVM_DEBUG statements to escaping capture diagnostics #65862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2023
Merged

[sil-optimizer] Add LLVM_DEBUG statements to escaping capture diagnostics #65862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion lib/SILOptimizer/Mandatory/DiagnoseInvalidEscapingCaptures.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
//
//===----------------------------------------------------------------------===//

#define DEBUG_TYPE "sil-diagnose-invalid-escaping-captures"

#include "swift/AST/ASTContext.h"
#include "swift/AST/DiagnosticsSIL.h"
#include "swift/AST/Expr.h"
Expand Down Expand Up @@ -199,6 +201,8 @@ bool isUseOfSelfInInitializer(Operand *oper) {
}

static bool checkForEscapingPartialApplyUses(PartialApplyInst *PAI) {
LLVM_DEBUG(llvm::dbgs() << "Checking for escaping partial apply uses.\n");

// Avoid exponential path exploration.
SmallVector<Operand *, 8> uses;
llvm::SmallDenseSet<Operand *, 8> visited;
Expand All @@ -215,10 +219,16 @@ static bool checkForEscapingPartialApplyUses(PartialApplyInst *PAI) {
bool foundEscapingUse = false;
while (!uses.empty()) {
Operand *oper = uses.pop_back_val();
foundEscapingUse |= checkNoEscapePartialApplyUse(oper, [&](SILValue V) {
LLVM_DEBUG(llvm::dbgs() << "Visiting user: " << *oper->getUser());
bool localFoundEscapingUse = checkNoEscapePartialApplyUse(oper, [&](SILValue V) {
for (Operand *use : V->getUses())
uselistInsert(use);
});
LLVM_DEBUG(
if (localFoundEscapingUse)
llvm::dbgs() << " Escapes!\n";
);
foundEscapingUse |= localFoundEscapingUse;
}

// If there aren't any, we're fine.
Expand Down Expand Up @@ -350,6 +360,8 @@ static void checkPartialApply(ASTContext &Context, DeclContext *DC,
if (isPartialApplyOfReabstractionThunk(PAI))
return;

LLVM_DEBUG(llvm::dbgs() << "Checking Partial Apply: " << *PAI);

ApplySite apply(PAI);

// Collect any non-escaping captures.
Expand Down Expand Up @@ -584,6 +596,8 @@ class DiagnoseInvalidEscapingCaptures : public SILFunctionTransform {
if (F->wasDeserializedCanonical())
return;

LLVM_DEBUG(llvm::dbgs() << "*** Diagnosing escaping captures in function: "
<< F->getName() << '\n');
checkEscapingCaptures(F);
}
};
Expand Down