[5.9-20230510][ModuleInterface] Add mechanism to exclude experimental flags from th… #66134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiftlang#66088) (swiftlang#66101) * [ModuleInterface] Add mechanism to exclude experimental flags from the module interface rdar://109722548 * Separate filtered flags from the typical/unfiltered case
drexin
changed the title
Contributor
Author
|
@swift-ci test |
tshortli
approved these changes
May 25, 2023
nkcsgexi
reviewed
May 25, 2023
|
|
||
| /// Checks if an arg is generally allowed to be included | ||
| /// in a module interface | ||
| static bool ShouldIncludeModuleInterfaceArg(const Arg *A) { |
Contributor
There was a problem hiding this comment.
nitpick: a more descriptive name for this function can be something like ShouldIncludeExperimentalFeatureFlagInModuleInterface.
nkcsgexi
approved these changes
May 25, 2023
tbkka
approved these changes
May 25, 2023
Contributor
Author
|
@swift-ci test macos |
3 similar comments
Contributor
Author
|
@swift-ci test macos |
Contributor
Author
|
@swift-ci test macos |
Contributor
Author
|
@swift-ci test macos |
Contributor
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.9-20230510 cherry-pick of #66088
Explanation: Adds a mechanism to exclude experimental flags from the module interface, so they are not exposed unless necessary for module generation.
Scope: Module interface generation
Issue: rdar://109722548
Risk: Low. Only affects experimental flags
Testing: Added test to check exclusion of flags marked for exclusion
Reviewer: @tshortli @DougGregor