🍒[cxx-interop] Add std::set initializer that takes a Swift Sequence
#66600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
hyp
reviewed
Jun 13, 2023
DougGregor
approved these changes
Jun 13, 2023
Contributor
Author
|
@swift-ci please test |
egorzhdan
force-pushed
the
egorzhdan/5.9-cxx-set-init
branch
from
625d95e to
f461353
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test macOS |
egorzhdan
force-pushed
the
egorzhdan/5.9-cxx-set-init
branch
from
f461353 to
af0050c
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
The tests are failing because #65105 is merged into |
egorzhdan
force-pushed
the
egorzhdan/5.9-cxx-set-init
branch
from
df34f50 to
37b45da
Compare
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: It was previously not possible to easily initialize an
std::setfrom a Swift Sequence. This change adds an extra initializer tostd::setthat takes a Swift Sequence as a parameter.Scope: This adds a requirement to the
CxxSetprotocol, adjusts the auto-conformance logic to check the new requirement, and adds an extra initializer toCxxSet.Risk: Low, this only has an effect when C++ interop is enabled.
rdar://107909624
(cherry picked from commit dd7e177)