[5.9] Fix insertion of dealloc_stack for partial_apply [on_stack] while going to non-OSSA #67163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to non-OSSA Instead of just inserting dealloc_stack on seeing a destroy_value for no escape closures. Go over all the lifetime ends of a partial_apply [on_stack] to insert dealloc_stack This ensures we don't miss cases where there is no destroying consuming of the no escape closures.
Contributor
Author
|
@swift-ci test |
tbkka
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Instead of just inserting dealloc_stack on seeing a destroy_value for no escape closures. Go over all the lifetime ends of a partial_apply [on_stack] to insert dealloc_stack This ensures we don't miss cases where there is no destroying consuming of the no escape closures.
Original PR: #65780
Testing: Added unit tests
Resolves: rdar://111810214