Skip to content

SILGen: Skip emitting non-exportable property wrapper backing inits #70363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tshortli merged 1 commit into from
Dec 11, 2023
Merged

SILGen: Skip emitting non-exportable property wrapper backing inits #70363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/SILGen/SILGen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1666,6 +1666,9 @@ emitStoredPropertyInitialization(PatternBindingDecl *pbd, unsigned i) {

void SILGenModule::
emitPropertyWrapperBackingInitializer(VarDecl *var) {
if (M.getOptions().SkipNonExportableDecls)
return;

auto initInfo = var->getPropertyWrapperInitializerInfo();

if (initInfo.hasInitFromWrappedValue()) {
Expand Down
21 changes: 21 additions & 0 deletions test/SILGen/skip_non_exportable_decls.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,17 @@ public var publicGlobalVar = 1
// CHECK: sil shared [serialized]{{.*}} @$s4Test023inlinableFuncWithNestedC0yyFyycyXEfU_ : $@convention(thin) () -> @owned @callee_guaranteed () -> () {
// CHECK: sil shared [serialized]{{.*}} @$s4Test023inlinableFuncWithNestedC0yyFyycyXEfU_6$deferL_yyF : $@convention(thin) () -> () {

@propertyWrapper
public struct PublicWrapper<T> {
// CHECK: sil [transparent] [serialized]{{.*}} @$s4Test13PublicWrapperV12wrappedValuexvg : $@convention(method) <T> (@in_guaranteed PublicWrapper<T>) -> @out T {
// CHECK: sil [transparent] [serialized]{{.*}} @$s4Test13PublicWrapperV12wrappedValuexvs : $@convention(method) <T> (@in T, @inout PublicWrapper<T>) -> () {
// CHECK: sil [transparent] [serialized]{{.*}} @$s4Test13PublicWrapperV12wrappedValuexvM : $@yield_once @convention(method) <T> (@inout PublicWrapper<T>) -> @yields @inout T {
public var wrappedValue: T

// CHECK: sil{{.*}} @$s4Test13PublicWrapperV12wrappedValueACyxGx_tcfC : $@convention(method) <T> (@in T, @thin PublicWrapper<T>.Type) -> @out PublicWrapper<T> {
public init(wrappedValue: T) { self.wrappedValue = wrappedValue }
}

private class PrivateClass {
// CHECK-NO-SKIP: sil private{{.*}} @$s4Test12PrivateClass33_CFB3F9DC47F5EF9E1D08B58758351A08LLCfd : $@convention(method) (@guaranteed PrivateClass) -> @owned Builtin.NativeObject {
// CHECK-SKIP-NOT: s4Test12PrivateClass33_CFB3F9DC47F5EF9E1D08B58758351A08LLCfd
Expand Down Expand Up @@ -124,6 +135,13 @@ public class PublicClass {
// CHECK: sil [transparent] [serialized]{{.*}} @$s4Test11PublicClassC9publicVarSivM : $@yield_once @convention(method) (@guaranteed PublicClass) -> @yields @inout Int {
public var publicVar = 1

// CHECK-NO-SKIP: sil{{.*}} @$s4Test11PublicClassC16publicWrappedVarSivpfP : $@convention(thin) (Int) -> PublicWrapper<Int> {
// CHECK-SKIP-NOT: s4Test11PublicClassC16publicWrappedVarSivpfP
// CHECK: sil{{.*}} @$s4Test11PublicClassC16publicWrappedVarSivg : $@convention(method) (@guaranteed PublicClass) -> Int {
// CHECK: sil{{.*}} @$s4Test11PublicClassC16publicWrappedVarSivs : $@convention(method) (Int, @guaranteed PublicClass) -> () {
// CHECK: sil{{.*}} @$s4Test11PublicClassC16publicWrappedVarSivM : $@yield_once @convention(method) (@guaranteed PublicClass) -> @yields @inout Int {
@PublicWrapper public var publicWrappedVar = publicGlobalVar

// CHECK-NO-SKIP: sil hidden{{.*}} @$s4Test11PublicClassC14internalMethodyyF : $@convention(method) (@guaranteed PublicClass) -> () {
// CHECK-SKIP-NOT: s4Test11PublicClassC14internalMethodyyF
internal func internalMethod() {}
Expand Down Expand Up @@ -166,6 +184,9 @@ extension PublicClass {
// CHECK-NEXT: #PublicClass.publicVar!getter
// CHECK-NEXT: #PublicClass.publicVar!setter
// CHECK-NEXT: #PublicClass.publicVar!modify
// CHECK-NEXT: #PublicClass.publicWrappedVar!getter
// CHECK-NEXT: #PublicClass.publicWrappedVar!setter
// CHECK-NEXT: #PublicClass.publicWrappedVar!modify
// CHECK-NO-SKIP-NEXT: #PublicClass.internalMethod
// CHECK-SKIP-NOT: #PublicClass.internalMethod
// CHECK-NO-SKIP-NEXT: #PublicClass.init!allocator
Expand Down