Skip to content

[Parse] Fix a couple of SourceRanges #71959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 29, 2024
Merged

[Parse] Fix a couple of SourceRanges #71959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/Parse/ParseDecl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1506,7 +1506,7 @@ bool Parser::parseExternAttribute(DeclAttributes &Attributes,
return false;
}

auto AttrRange = SourceRange(Loc, Tok.getLoc());
auto AttrRange = SourceRange(Loc, rParenLoc);

// Reject duplicate attributes with the same kind.
if (ExternAttr::find(Attributes, kind)) {
Expand Down Expand Up @@ -2329,7 +2329,7 @@ bool Parser::parseBackDeployedAttribute(DeclAttributes &Attributes,
}

assert(!PlatformAndVersions.empty());
auto AttrRange = SourceRange(Loc, Tok.getLoc());
auto AttrRange = SourceRange(Loc, RightLoc);
for (auto &Item : PlatformAndVersions) {
Attributes.add(new (Context) BackDeployedAttr(AtLoc, AttrRange, Item.first,
Item.second,
Expand Down
10 changes: 10 additions & 0 deletions test/SourceKit/Misc/rdar123405070.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// RUN: %sourcekitd-test -req=open %s -- %s
// Test that this doesn't crash sourcekitd

@_backDeploy(before: macOS 14.0)
@inline(never)
public func foo() {}

@_extern(wasm, module: "b", name: "c")
@_extern(c)
private func bar()