[build] Make the RegexParser requirement to build ASTGen explicit #77229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the requirement to have RegexParser build enabled more obvious to someone not familiar with ASTGen. This also removes the dummy target that was triggering build failures: certain Swift code in ASTGen was using `#if canImport(_CompilerRegexParser)` to determine whether RegexParser is available, and the dummy target was causing this to always resolve to true. That obscured the underlying reason for compilation errors: ``` ASTGen/Sources/ASTGen/Regex.swift:51:30: error: cannot find 'swiftCompilerLexRegexLiteral' in scope ```
egorzhdan
requested review from
CodaFi,
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
Contributor
Author
|
@swift-ci please smoke test |
| else() | ||
| # Dummy target for dependencies | ||
| add_custom_target(_CompilerRegexParser) | ||
| if(NOT SWIFT_BUILD_REGEX_PARSER_IN_COMPILER) |
Contributor
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the requirement to have RegexParser build enabled more obvious to someone not familiar with ASTGen.
This also removes the dummy target that was triggering build failures: certain Swift code in ASTGen was using
#if canImport(_CompilerRegexParser)to determine whether RegexParser is available, and the dummy target was causing this to always resolve to true. That obscured the underlying reason for compilation errors: