Skip to content

LifetimeDependenceDiagnostics: recognize store_borrow ranges #80173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025
Merged

LifetimeDependenceDiagnostics: recognize store_borrow ranges #80173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions SwiftCompilerSources/Sources/Optimizer/Utilities/LifetimeDependenceUtils.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,8 @@ extension LifetimeDependence.Scope {
range.insert(inst)
case let li as LoadInst where li.loadOwnership == .take:
range.insert(inst)
case is EndBorrowInst:
range.insert(inst)
default:
break
}
Expand Down
25 changes: 25 additions & 0 deletions test/SILOptimizer/lifetime_dependence/verify_diagnostics.sil
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,13 @@ struct NEObject : ~Escapable {
init()
}

public struct Holder {
var c: C
}

sil @makeNE : $@convention(thin) () -> @lifetime(immortal) @owned NE
sil @makeNEObject : $@convention(thin) () -> @lifetime(immortal) @owned NEObject
sil @useNE : $@convention(thin) (NE) -> ()

// Test returning a owned dependence on a trivial value
sil [ossa] @return_trivial_dependence : $@convention(thin) (@guaranteed C) -> @lifetime(borrow 0) @owned NE {
Expand All @@ -55,3 +60,23 @@ entry(%0 : @guaranteed $C):
%mark = mark_dependence [unresolved] %call : $NEObject on %zero : $Builtin.Int1
return %mark // expected-note {{this use causes the lifetime-dependent value to escape}}
}

// OK: Test that the range initialized by a store_borrow covers dependent uses.
sil [ossa] @testStoreBorrowRange : $@convention(thin) (@owned Holder) -> () {
bb0(%0 : @owned $Holder):
%val = move_value [lexical] [var_decl] %0
%stk = alloc_stack $Holder
%sb = store_borrow %val to %stk
%f1 = function_ref @makeNE : $@convention(thin) () -> @lifetime(immortal) @owned NE
%c1 = apply %f1() : $@convention(thin) () -> @lifetime(immortal) @owned NE
%md = mark_dependence [unresolved] %c1 on %sb
%mv = move_value [var_decl] %md
%f2 = function_ref @useNE : $@convention(thin) (NE) -> ()
%c2 = apply %f2(%mv) : $@convention(thin) (NE) -> ()
destroy_value %mv
end_borrow %sb
dealloc_stack %stk
destroy_value %val
%99 = tuple ()
return %99
}