Sema: Collected expression checking performance test cases from GitHub issues #84450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
reasonable-time-tests
branch
2 times, most recently
from
d38b3ec to
f2c9c21
Compare
|
@swift-ci Please test |
xedin
reviewed
Sep 22, 2025
| func slow() { | ||
| let _ = | ||
| (0x0041...0x005A).stringValue + // 'A' to 'Z' | ||
| (0x0061...0x007A).stringValue + // 'a' to 'z' |
There was a problem hiding this comment.
Seems like this might be a good candidate for a scale test as well?
There was a problem hiding this comment.
Perhaps, I thought it was interesting that it had two string literals in the middle too :)
There was a problem hiding this comment.
Yeah, we can keep that but do the loops in-between maybe?
AnthonyLatsis
approved these changes
Sep 23, 2025
slavapestov
force-pushed
the
reasonable-time-tests
branch
from
f2c9c21 to
2b546be
Compare
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
reasonable-time-tests
branch
from
2b546be to
2b1e506
Compare
|
@swift-ci Please test |
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the backlog of type checker performance bugs and reduced some test cases. Some are still slow, others were fixed a while ago, and a few were fixed in 6.2 or main.
Now fast:
Still slow: