Sema: Don't diagnose isolated deinit availability in skipped function bodies #84467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
hborla,
ktoso,
slavapestov and
xedin
as code owners
Contributor
Author
|
@swift-ci please smoke test |
tshortli
force-pushed
the
skip-isolated-deinit-availability-diags-during-emit-module
branch
from
b098aca to
be643cf
Compare
… bodies. As a follow-up fix for swiftlang#83545, avoid incorrectly diagnosing isolated deinit availability during module emission jobs, which skip type checking non-inlinable function bodies and therefore don't build accurate availability scopes for those bodies. It's ok to skip these diagnostics during module emission since they should still be emitted during compilation jobs. Resolves rdar://161178785.
tshortli
force-pushed
the
skip-isolated-deinit-availability-diags-during-emit-module
branch
from
be643cf to
ec0f3e3
Compare
Contributor
Author
|
@swift-ci please smoke test |
ktoso
approved these changes
Sep 24, 2025
tshortli
deleted the
skip-isolated-deinit-availability-diags-during-emit-module
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up fix for #83545, avoid incorrectly diagnosing
isolated deinitavailability during module emission jobs, which skip type checking non-inlinable function bodies and therefore don't build accurate availability scopes for those bodies. It's ok to skip these diagnostics during module emission since they should still be emitted during compilation jobs.Resolves rdar://161178785.