Skip to content

Sema: Don't diagnose isolated deinit availability in skipped function bodies #84467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

Sema: Don't diagnose isolated deinit availability in skipped function bodies #84467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/Sema/TypeCheckAttr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,12 @@ class AttributeChecker : public AttributeVisitor<AttributeChecker> {
}

if (!getActorIsolation(nominal).isMainActor() && destructor->hasBody()) {
// In module emission jobs, type checking the body of the destructor may
// be skipped which means availability in the body cannot be diagnosed
// accurately.
if (destructor->isBodySkipped())
return;

TypeChecker::checkAvailability(
destructor->getBodySourceRange(), C.getIsolatedDeinitAvailability(),
D->getDeclContext(),
Expand Down
5 changes: 5 additions & 0 deletions test/Concurrency/deinit_isolation_availability.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
// RUN: %target-typecheck-verify-swift -swift-version 5 %s -strict-concurrency=complete -target %target-swift-6.1-abi-triple
// RUN: %target-typecheck-verify-swift -swift-version 5 %s -strict-concurrency=complete -target %target-swift-6.1-abi-triple -target-min-inlining-version min -verify-additional-prefix inlining-

// Test -emit-module configurations.

// RUN: %target-swift-frontend -emit-module -verify -swift-version 5 %s -strict-concurrency=complete -target %target-swift-5.1-abi-triple -experimental-skip-non-inlinable-function-bodies -verify-additional-prefix inlining-
// RUN: %target-swift-frontend -emit-module -verify -swift-version 5 %s -strict-concurrency=complete -target %target-swift-6.1-abi-triple -experimental-skip-non-inlinable-function-bodies -target-min-inlining-version min -verify-additional-prefix inlining-

// REQUIRES: concurrency
// REQUIRES: OS=macosx

Expand Down