Parser: Reject @c attributes using the string format
#84489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xymus
requested review from
CodaFi,
DougGregor,
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Windows |
xymus
force-pushed
the
c-identifier-only
branch
from
51dcba6 to
32fead1
Compare
|
@swift-ci Please smoke test |
Reject `@c` attributes in the format of `@c("customName")` to accept
only `@c(customName)` and of course the bare `@c`.
xymus
force-pushed
the
c-identifier-only
branch
from
32fead1 to
7ec1d36
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reject
@cattributes using strings, in the style of@c("customName"), and accept only@c(customName)and the bare@c. Update all tests along with it.