Skip to content

[DeadObjectElim] Bail on invalid access path. #84776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2025
Merged

[DeadObjectElim] Bail on invalid access path. #84776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/SILOptimizer/Transforms/DeadObjectElimination.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,8 @@ static bool onlyStoresToTailObjects(BuiltinInst *destroyArray,

// Check if the destroyArray destroys the tail elements of allocRef.
auto destroyPath = AccessPath::compute(destroyArray->getArguments()[1]);
if (!destroyPath.isValid())
return false;
AccessStorage storage = destroyPath.getStorage();
if (auto *beginDealloc = dyn_cast<BeginDeallocRefInst>(storage.getRoot())) {
destroyPath = AccessPath(
Expand Down
17 changes: 17 additions & 0 deletions validation-test/SILOptimizer/rdar162237650.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
// RUN: %target-swift-frontend -c -O %s -target %target-swift-6.0-abi-triple

// REQUIRES: synchronization

import Synchronization

class Locked<T> {
let mutex: Mutex<T>

init(_ rawValue: T) {
mutex = Mutex(rawValue)
}
}

class Foo {}

_ = Locked(Foo())