[Swiftify] Don't use unsafe for Unsafe[Mut][Raw]BufferPointer.count
#84837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the type is unsafe, the count is marked `@safe`, and this use of `unsafe` results in a warning (regardless of whether strict memory safety is enabled or not). Keep emitting `unsafe` when the pointer buffer is wrapped in Optional for now however, because that is currently flagged as unsafe. rdar://162416566
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
I don't know why these tests weren't failing, but I did see this warning when testing other stuff, and when I accidentally removed |
Xazax-hun
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the type is unsafe, the count is marked
@safe, and this use ofunsaferesults in a warning (regardless of whether strict memory safety is enabled or not).Keep emitting
unsafewhen the pointer buffer is wrapped in Optional for now however, because that is currently flagged as unsafe.rdar://162416566