Skip to content

AssemblyVision: Add assemblyvisionremarkgen-diagnose-copy-destroy-addr option and use it #84856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

AssemblyVision: Add assemblyvisionremarkgen-diagnose-copy-destroy-addr option and use it #84856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions lib/SILOptimizer/Transforms/AssemblyVisionRemarkGenerator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,13 @@ static llvm::cl::opt<bool> DecllessDebugValueUseSILDebugInfo(
"write SIL test cases for this pass"),
llvm::cl::init(false));

static llvm::cl::opt<bool> DiagnoseCopyDestroyAddr(
"assemblyvisionremarkgen-diagnose-copy-destroy-addr", llvm::cl::Hidden,
llvm::cl::desc(
"Emit opt remarks for copy_addr, destroy_addr instructions"),
llvm::cl::init(true));


//===----------------------------------------------------------------------===//
// Value To Decl Inferrer
//===----------------------------------------------------------------------===//
Expand Down Expand Up @@ -568,6 +575,9 @@ struct AssemblyVisionRemarkGeneratorInstructionVisitor

void AssemblyVisionRemarkGeneratorInstructionVisitor::
visitCopyAddrInst(CopyAddrInst *copy) {
if (!DiagnoseCopyDestroyAddr)
return;

ORE.emit([&]() {
using namespace OptRemark;
SmallVector<Argument, 8> inferredArgs;
Expand Down Expand Up @@ -603,6 +613,9 @@ void AssemblyVisionRemarkGeneratorInstructionVisitor::

void AssemblyVisionRemarkGeneratorInstructionVisitor::
visitDestroyAddrInst(DestroyAddrInst *destroy) {
if (!DiagnoseCopyDestroyAddr)
return;

ORE.emit([&]() {
using namespace OptRemark;
SmallVector<Argument, 8> inferredArgs;
Expand Down
2 changes: 1 addition & 1 deletion test/SILOptimizer/assemblyvision_remark/cast_remarks.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// RUN: %target-swiftc_driver -O -Rpass-missed=sil-assembly-vision-remark-gen -Xfrontend -enable-copy-propagation=requested-passes-only -Xfrontend -enable-lexical-lifetimes=false -Xllvm -sil-disable-pass=FunctionSignatureOpts -emit-sil %s -o /dev/null -Xfrontend -verify
// RUN: %target-swiftc_driver -O -Xllvm -assemblyvisionremarkgen-diagnose-copy-destroy-addr=false -Rpass-missed=sil-assembly-vision-remark-gen -Xfrontend -enable-copy-propagation=requested-passes-only -Xfrontend -enable-lexical-lifetimes=false -Xllvm -sil-disable-pass=FunctionSignatureOpts -emit-sil %s -o /dev/null -Xfrontend -verify

// REQUIRES: optimized_stdlib
// REQUIRES: swift_stdlib_no_asserts
Expand Down
2 changes: 1 addition & 1 deletion test/SILOptimizer/assemblyvision_remark/cast_remarks_objc.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// RUN: %target-swiftc_driver -O -Rpass-missed=sil-assembly-vision-remark-gen -Xllvm -sil-disable-pass=FunctionSignatureOpts -emit-sil %s -o /dev/null -Xfrontend -verify
// RUN: %target-swiftc_driver -O -Xllvm -assemblyvisionremarkgen-diagnose-copy-destroy-addr=false -Rpass-missed=sil-assembly-vision-remark-gen -Xllvm -sil-disable-pass=FunctionSignatureOpts -emit-sil %s -o /dev/null -Xfrontend -verify

// REQUIRES: objc_interop
// REQUIRES: optimized_stdlib
Expand Down