sema: avoid diagnosing typed_throw_in_objc_forbidden in textual interface files #84864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…face files PR swiftlang#81054 introduced diagnostics for that @objc function shouldn't be using typed throws. Emitting this fatal diagnostics in Swift textual interface files seems to be redundant because (1) it should be already diagnosed in the source code, and (2) downstream clients have no control over the contents of upstream textual interfaces. rdar://162138214
tshortli
approved these changes
Oct 13, 2025
Contributor
Author
|
@swift-ci please smoke text |
1 similar comment
Contributor
Author
|
@swift-ci please smoke text |
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #81054 introduced diagnostics for that @objc function shouldn't be using typed throws. Emitting this fatal diagnostics in Swift textual interface files seems to be redundant because (1) it should be already diagnosed in the source code, and (2) downstream clients have no control over the contents of upstream textual interfaces.
rdar://162138214