[Swiftify] Always skip safe wrappers when building the stdlib #84872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_SwiftifyImport assumes types like Swift.Int, Swift.UnsafePointer<T> and Swift.Span<T> are available. This is not the case when building the stdlib itself. Disable safe interop in the stdlib to prevent errors. This currently has no effect, but will when this feature is enabled by default, which I have manually tested.
hnrklssn
requested review from
DougGregor,
Xazax-hun,
artemcm,
beccadax,
egorzhdan,
fahadnayyar,
ian-twilightcoder,
j-hui,
susmonteiro,
tshortli and
zoecarver
as code owners
Member
Author
|
@swift-ci please smoke test |
Xazax-hun
approved these changes
Oct 14, 2025
|
|
||
| /// Whether the importer should skip SafeInteropWrappers, even though the | ||
| /// feature is enabled. | ||
| bool DisableSafeInteropWrappers = false; |
Contributor
There was a problem hiding this comment.
Do we anticipate other cases where we want to disable the wrappers? I wonder if we should always check directly for whether we are building the stdlib instead of having a new flag. I have no strong feelings here though.
Member
Author
There was a problem hiding this comment.
I don't know of any other cases, but ClangImporter doesn't seem to have access to swift::FrontendOptions from what I could tell.
Member
There was a problem hiding this comment.
Hmm. We have -disable-experimental-feature, although I'm not sure if we model having an on-by-default feature that is then disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_SwiftifyImport assumes types like Swift.Int, Swift.UnsafePointer and Swift.Span are available. This is not the case when building the stdlib itself. Disable safe interop in the stdlib to prevent errors. This currently has no effect, but will when this feature is enabled by default, which I have manually tested.