Even more type checker perf tests #84890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irectory They're actually fast. Also, change -solver-expression-time-threshold=1 into a scope limit to make it deterministic.
|
@swift-ci Please smoke test |
|
@swift-ci Please test Windows |
|
@swift-ci Please smoke test macOS |
xedin
approved these changes
Oct 14, 2025
| // RUN: %target-typecheck-verify-swift -solver-scope-threshold=300 | ||
|
|
||
| func slow(someOptionalString: String?) { | ||
| print("\(someOptionalString ?? "")\(someOptionalString ?? "")\(someOptionalString ?? "")\(someOptionalString ?? "")\(someOptionalString ?? "")\(someOptionalString ?? "")\(someOptionalString ?? "")\(someOptionalString ?? "")\(someOptionalString ?? "")\(someOptionalString ?? "")\(someOptionalString ?? "")\(someOptionalString ?? "")\(someOptionalString ?? "")") |
There was a problem hiding this comment.
I vaguely remember one with a bunch of ?? operators like that in the suite, could you please double-check if we already have it?
There was a problem hiding this comment.
We had a bunch with ?? but this one also has string interpolation. Do you think it’s worth keeping?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are now fast:
minon matrix elements #46430