We need at least 7 samples for scale-test to produce a reliable result #84922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please smoke test |
slavapestov
commented
Oct 15, 2025
| @@ -1,4 +1,4 @@ | |||
| // RUN: %scale-test --invert-result --begin 2 --end 5 --step 1 --select NumLeafScopes %s | |||
| // RUN: %scale-test --invert-result --begin 2 --end 6 --step 1 --select NumLeafScopes %s | |||
Contributor
Author
There was a problem hiding this comment.
This is 6 because we diagnose 'too complex' at 7
One test was miscategorized as 'fast' because of this issue, but it would occasionally fail. It turns out it always fails once you ask for 7 points or more, so let's fix that and move it back to 'slow'. Fixes rdar://162597936.
slavapestov
force-pushed
the
fix-flaky-scale-test
branch
from
21e0736 to
0aece0c
Compare
Contributor
Author
|
@swift-ci Please smoke test |
xedin
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One test was miscategorized as 'fast' because of this issue, but it would occasionally fail. It turns out it always fails once you ask for 7 points or more, so let's fix that and move it back to 'slow'.
Fixes rdar://162597936.