SIL: streamline Operand Sequence APIs #84949
Merged
+34
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove `filterUsers(ofType:)`, because it's a duplication of `users(ofType:)` * rename `filterUses(ofType:)` -> `filter(usersOfType:)` * rename `ignoreUses(ofType:)` -> `ignore(usersOfType:)` * rename `getSingleUser` -> `singleUser` * implement `singleUse` with `Sequence.singleElement` * implement `ignoreDebugUses` with `ignore(usersOfType:)` This is a follow-up of swiftlang@eb1d5f4.
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci smoke test macos |
atrick
approved these changes
Oct 16, 2025
Contributor
atrick
left a comment
atrick
left a comment
There was a problem hiding this comment.
In general, I think the method name should reflect the behavior rather than relying on argument labels. For example, folding the closure argument of filter should usually refine the method name:
Sequence<Int>.filterDivisible(by: 7)
As Erik explained, the name should not repeat Uses, which would be redundant. And the name should not say Users since it actually returns Operand not Instruction. So any of these are valid:
filterType(_:)filter(type:)filter(usersOfType:)
I slightly prefer the less verbose options since I think users is redundant with type. But any of the above are ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filterUsers(ofType:), because it's a duplication ofusers(ofType:)filterUses(ofType:)->filter(usersOfType:)ignoreUses(ofType:)->ignore(usersOfType:)getSingleUser->singleUsersingleUsewithSequence.singleElementignoreDebugUseswithignore(usersOfType:)This is a follow-up of eb1d5f4.