Serialization: Fix null dereference in witness deserialization #84958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix null dereference in deserialization logic for conformances. If deserializing the witness itself failed, don't try to get its actor isolation. rdar://162158608
bnbarham
approved these changes
Oct 16, 2025
Contributor
Author
|
@swift-ci Please smoke test |
slavapestov
reviewed
Oct 16, 2025
Contributor
slavapestov
left a comment
slavapestov
left a comment
There was a problem hiding this comment.
Is there an easy test case you could add?
Contributor
Author
|
I don't have a test for this one as I worked backwards from the crashlog and it looked like a simple oversight in the actor isolation logic. If we already have a reproducer for failures at deserializing witnesses, adding an extra attribute may trigger this one. |
Contributor
Author
|
@swift-ci Please smoke test Windows |
1 similar comment
Contributor
Author
|
@swift-ci Please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix null dereference in deserialization logic for conformances. If deserializing the witness itself failed, don't try to get its actor isolation.
rdar://162158608