CMake: add Observation dependency to libraries that import Foundation... #84964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when building for Apple platforms. In this scenario we are not building our own Foundation, but we are importing the one from the underlying SDK -- this in turns requires Observation, which is something we typically build. Addresses rdar://162286123
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please test Apple Silicon |
phausler
approved these changes
Oct 16, 2025
Contributor
phausler
left a comment
phausler
left a comment
There was a problem hiding this comment.
Out of the strategies available this seems to be the least friction imho.
etcwilde
approved these changes
Oct 16, 2025
Contributor
Author
|
@swift-ci please test Apple Silicon |
Contributor
Author
|
@swift-ci please smoke test macOS |
edymtt
deleted the
edymtt/add-observation-dependency-to-foundation-users
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when building for Apple platforms.
In this scenario we are not building our own Foundation, but we are importing the one from the underlying SDK -- this in turns requires Observation, which is something we typically build.
Addresses rdar://162286123