[cxx-interop] Do not treat SWIFT_RETURNS_INDEPENDENT_VALUE unsafe #84980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
beccadax,
egorzhdan,
fahadnayyar,
hnrklssn,
ian-twilightcoder,
j-hui,
susmonteiro and
zoecarver
as code owners
The explicit safety analysis inadvertently considered every instance method with this annotation unsafe. We trust these annotations, so let's not consider the annotated methods unsafe. rdar://162602614
Xazax-hun
force-pushed
the
unsafe-independent-value
branch
from
1d08e81 to
69f0a7d
Compare
Contributor
Author
|
@swift-ci please smoke test |
egorzhdan
approved these changes
Oct 17, 2025
j-hui
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The explicit safety analysis inadvertently considered every instance method with this annotation unsafe. We trust these annotations, so let's not consider the annotated methods unsafe.
rdar://162602614