[Sema]: minor improvements to unused expression result diagnostics #85113
+83
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would emit a diagnostic in cases in which a throwing function returning a structurally-uninhabited type was called within an optional try expression. Such cases can never produce a result other than
nil, so the existing diagnostic seemed not particularly helpful. This change attempts to address this and other minor inconsistencies by expanding theisDiscardableType()logic to encompass "structurally uninhabited" types (e.g. tuples that eventually bottom out in an uninhabited type in some position), and also look through any levels of optionality to find such types. This makes the unused expression result diagnostics a bit more consistent in that they will now allow 'uninteresting' unused results to be implicitly discarded. In particular, the following cases now have the same diagnostic behavior (namely, do not produce a warning for the unused results):Resolves: #85092